-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update templated files #1122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Owlbot failed. It didn't get past step one in the owlbot processing. That caused all the other steps to fail. I tried to run it locally ... there is a nox run command near the end of the owlbot.py file that fails cause it could not write (presumably inside the docker container the command is supposed to be running in). I do not know if my local issue is the same as the one affecting this PR. In reviewing the code included in this PR, I am curious about the change to the I see that it is identical to the change in the PR you reference. Was your change manually generated by you OR automagically generated by a file update script as part of owlbot processing OR running the owlbot cli. The reason I ask... I was under the impression that that file gets automagically updated via an update script, not manually and thus there may be other changes to the files. Also... I notice there is no change to the |
@chalmerlowe Thanks a lot for helping with the investigation! After talking with @ohmayr, it seems we had duplicated configs in |
Similar to googleapis/google-auth-library-python#1597, this PR updates the template version, so owlbot updates can be triggered. I'm doing this because this release #1075 failed (successful commit, failed PyPI upload) is highly likely to be caused by an outdated PyPI key. With the key updated we can rerun the release job and it should be able to upload.