Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update templated files #1122

Merged
merged 15 commits into from
Oct 2, 2024
Merged

Conversation

Linchin
Copy link
Contributor

@Linchin Linchin commented Sep 30, 2024

Similar to googleapis/google-auth-library-python#1597, this PR updates the template version, so owlbot updates can be triggered. I'm doing this because this release #1075 failed (successful commit, failed PyPI upload) is highly likely to be caused by an outdated PyPI key. With the key updated we can rerun the release job and it should be able to upload.

@Linchin Linchin requested review from a team as code owners September 30, 2024 21:36
@Linchin Linchin self-assigned this Sep 30, 2024
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 30, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Sep 30, 2024
@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2024
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe
Copy link
Collaborator

chalmerlowe commented Oct 1, 2024

Owlbot failed. It didn't get past step one in the owlbot processing. That caused all the other steps to fail. I tried to run it locally ... there is a nox run command near the end of the owlbot.py file that fails cause it could not write (presumably inside the docker container the command is supposed to be running in). I do not know if my local issue is the same as the one affecting this PR.

In reviewing the code included in this PR, I am curious about the change to the owlbot.lock.yaml file:

I see that it is identical to the change in the PR you reference. Was your change manually generated by you OR automagically generated by a file update script as part of owlbot processing OR running the owlbot cli.

The reason I ask... I was under the impression that that file gets automagically updated via an update script, not manually and thus there may be other changes to the files.

Also... I notice there is no change to the pypi token identifier in this PR. Is that intentional? See this line in Anthonios' PR (I think the new token is token 2.): https://github.com/googleapis/google-auth-library-python/blob/8992bc9593173d3429d6ffd2651980e0ddf73dd7/.kokoro/release/common.cfg#L31

@Linchin Linchin added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2024
@ohmayr ohmayr added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 1, 2024
@Linchin Linchin added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Oct 1, 2024
@Linchin Linchin added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2024
@Linchin
Copy link
Contributor Author

Linchin commented Oct 1, 2024

@chalmerlowe Thanks a lot for helping with the investigation! After talking with @ohmayr, it seems we had duplicated configs in owlbot.py and setup.cfg, and this led to owlbot being unable to update the script. After removing the copy in owlbot.py, as you can see owlbot added the updates it synced from the templates, which includes the key update.

@Linchin Linchin added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2024
@Linchin Linchin added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2024
@Linchin Linchin added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2024
@Linchin Linchin added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 2, 2024
@Linchin Linchin added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 2, 2024
@Linchin Linchin added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 2, 2024
@Linchin Linchin merged commit a8e81fb into googleapis:main Oct 2, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants