Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move retry async check to wrap time #668

Merged
merged 7 commits into from
Oct 21, 2024
Merged

chore: move retry async check to wrap time #668

merged 7 commits into from
Oct 21, 2024

Conversation

parthea
Copy link
Collaborator

@parthea parthea commented Jun 5, 2024 •
edited
Loading

Opening a new PR to restore the features in #649 which were reverted in #667 due to tests failing in cl/640306895

cc @daniel-sanche

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jun 5, 2024
daniel-sanche
daniel-sanche approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea parthea self-assigned this Oct 9, 2024
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 9, 2024
@parthea parthea changed the title Move async warning chore: move retry async check to wrap time Oct 21, 2024
@parthea parthea added the status: investigating The issue is under investigation, which is determined to be non-trivial. label Oct 21, 2024
@parthea
Copy link
Collaborator Author

parthea commented Oct 21, 2024 •
edited
Loading

Waiting for test results in cl/688122871 Tests passed

@parthea parthea removed status: investigating The issue is under investigation, which is determined to be non-trivial. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 21, 2024
@parthea parthea marked this pull request as ready for review October 21, 2024 14:45
@parthea parthea requested review from a team as code owners October 21, 2024 14:45
@parthea parthea merged commit 3c69867 into main Oct 21, 2024
43 checks passed
@parthea parthea deleted the move_async_warning branch October 21, 2024 14:46
parthea added a commit that referenced this pull request Oct 22, 2024
@parthea
Revert "chore: move retry async check to wrap time (#668)"
c4880c3 
This reverts commit 3c69867.
@parthea parthea mentioned this pull request Oct 22, 2024
Merged
parthea added a commit that referenced this pull request Oct 22, 2024
@parthea
chore: Revert "chore: move retry async check to wrap time (#668)" (#743)
7727405 
This reverts commit 3c69867.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

Assignees

@parthea parthea

Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthea @daniel-sanche