Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export LogSeverity for type enforcement #1485

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: export LogSeverity for type enforcement #1485

wants to merge 9 commits into from

Conversation

cindy-peng
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1402 🦕

@cindy-peng cindy-peng requested review from a team as code owners January 22, 2024 21:44
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/nodejs-logging API. labels Jan 22, 2024
@cindy-peng cindy-peng self-assigned this Jan 22, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: xs Pull request size is extra small. labels Jan 22, 2024
@cindy-peng cindy-peng force-pushed the cindy/ExportSeverity branch from 04d76bf to f669fc1 Compare January 24, 2024 01:39
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: xl Pull request size is extra large. labels Jan 24, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: xs Pull request size is extra small. labels Jan 24, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: xl Pull request size is extra large. labels Jan 24, 2024
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Feb 22, 2024
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Mar 23, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Apr 9, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: m Pull request size is medium. labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche Awaiting requested review from daniel-sanche daniel-sanche is a code owner automatically assigned from googleapis/api-logging

At least 1 approving review is required to merge this pull request.

Assignees

@cindy-peng cindy-peng

Labels
api: logging Issues related to the googleapis/nodejs-logging API. size: xs Pull request size is extra small. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LogSeverity not exported from @google-cloud/logging.
1 participant
@cindy-peng