Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use composite action #1694

Merged
merged 3 commits into from
Sep 26, 2024
Merged

chore: use composite action #1694

merged 3 commits into from
Sep 26, 2024

Conversation

JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented Sep 26, 2024 •
edited
Loading

In this PR:

  • Use composite action defined in sdk-platform-java to reduce code duplication

@generated-files-bot Generated Files Bot
Copy link

generated-files-bot bot commented Sep 26, 2024 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/BigQueryOptions.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/BigQueryOptionsOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/CmekSettings.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/CmekSettingsOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/CreateBucketRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/CreateBucketRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/CreateExclusionRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/CreateExclusionRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/CreateLogMetricRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/CreateLogMetricRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/CreateSinkRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/CreateSinkRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/CreateViewRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/CreateViewRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/DeleteBucketRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/DeleteBucketRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/DeleteExclusionRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/DeleteExclusionRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/DeleteLogMetricRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/DeleteLogMetricRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/DeleteLogRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/DeleteLogRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/DeleteSinkRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/DeleteSinkRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/DeleteViewRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/DeleteViewRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/GetBucketRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/GetBucketRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/GetCmekSettingsRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/GetCmekSettingsRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/GetExclusionRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/GetExclusionRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/GetLogMetricRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/GetLogMetricRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/GetSinkRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/GetSinkRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/GetViewRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/GetViewRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LifecycleState.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListBucketsRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListBucketsRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListBucketsResponse.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListBucketsResponseOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListExclusionsRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListExclusionsRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListExclusionsResponse.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListExclusionsResponseOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListLogEntriesRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListLogEntriesRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListLogEntriesResponse.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListLogEntriesResponseOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListLogMetricsRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListLogMetricsRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListLogMetricsResponse.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListLogMetricsResponseOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListLogsRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListLogsRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListLogsResponse.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListLogsResponseOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListMonitoredResourceDescriptorsRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListMonitoredResourceDescriptorsRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListMonitoredResourceDescriptorsResponse.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListMonitoredResourceDescriptorsResponseOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListSinksRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListSinksRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListSinksResponse.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListSinksResponseOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListViewsRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListViewsRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListViewsResponse.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/ListViewsResponseOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogBucket.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogBucketOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogEntry.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogEntryOperation.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogEntryOperationOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogEntryOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogEntryProto.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogEntrySourceLocation.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogEntrySourceLocationOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogExclusion.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogExclusionOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogMetric.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogMetricOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogSink.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogSinkOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogView.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LogViewOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LoggingConfigProto.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LoggingMetricsProto.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/LoggingProto.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/TailLogEntriesRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/TailLogEntriesRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/TailLogEntriesResponse.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/TailLogEntriesResponseOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/UndeleteBucketRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/UndeleteBucketRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/UpdateBucketRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/UpdateBucketRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/UpdateCmekSettingsRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/UpdateCmekSettingsRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/UpdateExclusionRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/UpdateExclusionRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/UpdateLogMetricRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/UpdateLogMetricRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/UpdateSinkRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/UpdateSinkRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/UpdateViewRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/UpdateViewRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/WriteLogEntriesPartialErrors.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/WriteLogEntriesPartialErrorsOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/WriteLogEntriesRequest.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/WriteLogEntriesRequestOrBuilder.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/WriteLogEntriesResponse.java
  • proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/WriteLogEntriesResponseOrBuilder.java

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: logging Issues related to the googleapis/java-logging API. labels Sep 26, 2024
@JoeWang1127 JoeWang1127 marked this pull request as ready for review September 26, 2024 00:18
@JoeWang1127 JoeWang1127 requested review from a team as code owners September 26, 2024 00:18
@JoeWang1127 JoeWang1127 merged commit 9fbc3f2 into main Sep 26, 2024
23 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/use-composite-action branch September 26, 2024 18:08
@JoeWang1127 JoeWang1127 mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cindy-peng cindy-peng cindy-peng approved these changes

@gkevinzheng gkevinzheng Awaiting requested review from gkevinzheng gkevinzheng is a code owner automatically assigned from googleapis/api-logging

Assignees

@cindy-peng cindy-peng

Labels
api: logging Issues related to the googleapis/java-logging API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoeWang1127 @cindy-peng @cloud-java-bot