Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove obsolete release job configs #1507

Merged
merged 5 commits into from
Jan 30, 2024
Merged

chore: remove obsolete release job configs #1507

merged 5 commits into from
Jan 30, 2024

Conversation

alicejli
Copy link
Contributor

@alicejli alicejli commented Jan 11, 2024 •
edited
Loading

Release config is now managed internally.

The requirements.txt and requirements.in files are now unused here.

Note that I had to add entries in owlbot.py because they are templated files.

Related to b/296905003

Based on googleapis/java-firestore#1404

@alicejli alicejli requested review from a team as code owners January 11, 2024 18:45
@alicejli alicejli requested a review from gkevinzheng January 11, 2024 18:45
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jan 11, 2024
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/release/bump_snapshot.cfg
  • .kokoro/release/common.cfg
  • .kokoro/release/common.sh
  • .kokoro/release/drop.cfg
  • .kokoro/release/drop.sh
  • .kokoro/release/promote.cfg
  • .kokoro/release/promote.sh
  • .kokoro/release/publish_javadoc.cfg
  • .kokoro/release/publish_javadoc.sh
  • .kokoro/release/publish_javadoc11.cfg
  • .kokoro/release/publish_javadoc11.sh
  • .kokoro/release/snapshot.cfg
  • .kokoro/release/snapshot.sh
  • .kokoro/release/stage.cfg
  • .kokoro/release/stage.sh

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Jan 11, 2024
@alicejli alicejli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2024
@suztomo
Copy link
Member

suztomo commented Jan 30, 2024

requirements.txt is not part of this change?

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 30, 2024
@alicejli
Copy link
Contributor Author

requirements.txt is not part of this change?

Good catch - have updated.

@alicejli alicejli merged commit 5f74725 into main Jan 30, 2024
23 checks passed
@alicejli alicejli deleted the rel-cleanup branch January 30, 2024 19:01
@alicejli alicejli mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

@gkevinzheng gkevinzheng Awaiting requested review from gkevinzheng gkevinzheng is a code owner automatically assigned from googleapis/api-logging

Assignees

@cindy-peng cindy-peng

Labels
api: logging Issues related to the googleapis/java-logging API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alicejli @suztomo @yoshi-kokoro @cindy-peng