Skip to content

Commit

Permalink
fix: restore batching for writeLogEntriesCallable (#754)
Browse files Browse the repository at this point in the history
handle regression which caused to writeLogEntriesCallable stub to use non aggregated gax method.

Fixes #744
  • Loading branch information
minherz authored Nov 22, 2021
1 parent 108919f commit 9b92d0a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion env-tests-logging
Submodule env-tests-logging updated 54 files
+7 −0 .github/CODEOWNERS
+3 −1 .gitignore
+36 −86 CODE_OF_CONDUCT.md
+1 −1 README.md
+28 −1 deployable/go/main.go
+1 −0 deployable/java/.dockerignore
+29 −0 deployable/java/.gitignore
+1 −0 deployable/java/.mvn/jvm.config
+117 −0 deployable/java/.mvn/wrapper/MavenWrapperDownloader.java
+ deployable/java/.mvn/wrapper/maven-wrapper.jar
+2 −0 deployable/java/.mvn/wrapper/maven-wrapper.properties
+47 −0 deployable/java/Dockerfile
+310 −0 deployable/java/mvnw
+182 −0 deployable/java/mvnw.cmd
+119 −0 deployable/java/pom.xml
+144 −0 deployable/java/src/main/java/envtest/deployable/DeployableApplication.java
+79 −0 deployable/java/src/main/java/envtest/deployable/Snippets.java
+91 −0 deployable/java/src/main/java/envtest/deployable/web/DeployableHttpController.java
+1 −0 deployable/java/src/main/resources/application.properties
+1 −0 deployable/nodejs/.gitignore
+8 −3 deployable/nodejs/Dockerfile
+5 −11 deployable/nodejs/app.js
+15 −4 deployable/nodejs/tests.js
+2 −0 deployable/python/.gitignore
+1 −1 deployable/python/Dockerfile
+2 −1 deployable/python/requirements.txt
+20 −0 deployable/python/snippets.py
+2 −2 envctl/env_scripts/go/cloudrun.sh
+2 −1 envctl/env_scripts/go/kubernetes.sh
+83 −0 envctl/env_scripts/java/appengine_flex.sh
+88 −0 envctl/env_scripts/java/appengine_standard.sh
+88 −0 envctl/env_scripts/java/cloudrun.sh
+69 −0 envctl/env_scripts/java/compute.sh
+118 −0 envctl/env_scripts/java/kubernetes.sh
+58 −0 envctl/env_scripts/java/local.sh
+1 −19 envctl/env_scripts/nodejs/cloudrun.sh
+1 −19 envctl/env_scripts/nodejs/compute.sh
+3 −19 envctl/env_scripts/nodejs/kubernetes.sh
+2 −1 envctl/env_scripts/python/kubernetes.sh
+14 −5 envctl/envctl
+4 −2 noxfile.py
+6 −0 renovate.json
+50 −8 tests/common/common.py
+55 −0 tests/common/python.py
+13 −0 tests/java/__init__.py
+26 −0 tests/java/test_appengine_flex.py
+26 −0 tests/java/test_appengine_standard.py
+35 −0 tests/java/test_cloudrun.py
+27 −0 tests/java/test_compute.py
+29 −0 tests/java/test_kubernetes.py
+2 −0 tests/nodejs/test_appengine_standard.py
+1 −1 tests/nodejs/test_cloudrun.py
+1 −0 tests/nodejs/test_functions.py
+1 −1 tests/nodejs/test_kubernetes.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ public Map<String, String> extract(ListLogsRequest request) {
callableFactory.createUnaryCallable(
deleteLogTransportSettings, settings.deleteLogSettings(), clientContext);
this.writeLogEntriesCallable =
callableFactory.createUnaryCallable(
callableFactory.createBatchingCallable(
writeLogEntriesTransportSettings, settings.writeLogEntriesSettings(), clientContext);
this.listLogEntriesCallable =
callableFactory.createUnaryCallable(
Expand Down

0 comments on commit 9b92d0a

Please sign in to comment.