Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: refactor grpc query splitter logic #1674

Merged
merged 12 commits into from
Dec 23, 2024

Conversation

cindy-peng
Copy link
Contributor

@cindy-peng cindy-peng commented Nov 21, 2024

With the new Gapic upgrade change, we are deprecating handwritten HTTP Datastore module datastore-v1-proto-client since it will be replaced with auto generated gRPC code. QuerySplitter is a class in datastore-v1-proto-client which is still used by Beam team. We want to refactor QuerySplitter and its related helper classes including DatatoreHelper.java into a new module google-cloud-datastore-utils in google-cloud-datastore so they will continue to be available for our customers while we deprecate datastore-v1-proto-client module.

For more details about the design decision, please refer here.

@cindy-peng cindy-peng requested review from a team as code owners November 21, 2024 18:27
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: datastore Issues related to the googleapis/java-datastore API. labels Nov 21, 2024
@cindy-peng cindy-peng changed the title Grpc query splitter refactor: refactor grpc query splitter logic Nov 21, 2024
@cindy-peng cindy-peng changed the title refactor: refactor grpc query splitter logic Refactor: refactor grpc query splitter logic Dec 22, 2024
@kevkim-codes kevkim-codes merged commit 4a18ad2 into grpc-experimental Dec 23, 2024
20 of 21 checks passed
@kevkim-codes kevkim-codes deleted the grpc-query-splitter branch December 23, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants