Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simplify remaining deadline metric impl #2410

Merged
merged 6 commits into from
Nov 13, 2024
Merged

fix: simplify remaining deadline metric impl #2410

merged 6 commits into from
Nov 13, 2024

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Nov 11, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf requested review from a team as code owners November 11, 2024 20:32
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Nov 11, 2024
@mutianf mutianf changed the title fix: clean up remaining deadline metric fix: simplify remaining deadline metric impl Nov 11, 2024
igorbernstein2
igorbernstein2 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comments are address

...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracer.java Outdated Show resolved Hide resolved
...ud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableTracer.java Outdated Show resolved Hide resolved
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Nov 13, 2024
@mutianf mutianf merged commit 9796d57 into googleapis:main Nov 13, 2024
20 of 21 checks passed
@mutianf mutianf deleted the cleanup branch November 13, 2024 15:52
@release-please release-please bot mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djyau djyau djyau left review comments

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mutianf @igorbernstein2 @djyau