Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make client side metrics tag in sync with server #2401

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Nov 4, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf requested review from a team as code owners November 4, 2024 21:27
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Nov 4, 2024
@mutianf mutianf added the automerge Merge the pull request once unit tests and other checks pass. label Nov 13, 2024
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 14, 2024
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Nov 19, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2024
Change-Id: I7fdcac0d3b29e12421f7fd46309cf8a6c80b5f51
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 19, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit bba4183 into googleapis:main Nov 19, 2024
21 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 19, 2024
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 19, 2024
🤖 I have created a release *beep* *boop*
---


## [2.48.0](https://togithub.com/googleapis/java-bigtable/compare/v2.47.0...v2.48.0) (2024-11-19)


### Features

* Enable trailer optimization by default ([#2421](https://togithub.com/googleapis/java-bigtable/issues/2421)) ([7b2c4e4](https://togithub.com/googleapis/java-bigtable/commit/7b2c4e45dce828f506dac16ffc2b71995564a477))


### Bug Fixes

* **deps:** Update the Java code generator (gapic-generator-java) to 2.50.0 ([6b35b47](https://togithub.com/googleapis/java-bigtable/commit/6b35b478e10efce77d95bffcd7a64e84e1bcc5b0))
* Make client side metrics tag in sync with server ([#2401](https://togithub.com/googleapis/java-bigtable/issues/2401)) ([bba4183](https://togithub.com/googleapis/java-bigtable/commit/bba41837febc10e9507afc7117e2e4ec2d15fb11))


### Dependencies

* Revert downgrade grpc to 1.67.1 [#2366](https://togithub.com/googleapis/java-bigtable/issues/2366) ([#2414](https://togithub.com/googleapis/java-bigtable/issues/2414)) ([710fa52](https://togithub.com/googleapis/java-bigtable/commit/710fa52a05ce4fc81ee8e980d87e0ca86676219f))
* Update dependency com.google.cloud:gapic-libraries-bom to v1.48.0 ([#2422](https://togithub.com/googleapis/java-bigtable/issues/2422)) ([2088a39](https://togithub.com/googleapis/java-bigtable/commit/2088a399bd8b71e98035cc475637f41d5873082d))
* Update sdk-platform-java dependencies ([#2418](https://togithub.com/googleapis/java-bigtable/issues/2418)) ([c12bb01](https://togithub.com/googleapis/java-bigtable/commit/c12bb01a6c5be0a72285db0505407f3e1c2534fb))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants