Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: clean up tests for traffic director #2376

Merged
merged 4 commits into from
Oct 11, 2024
Merged

test: clean up tests for traffic director #2376

merged 4 commits into from
Oct 11, 2024

Conversation

igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Oct 10, 2024

  • add ability to override the app profile for a test run
  • ensure to skip the metrics it test since it uses an ephemeral app profile
  • add interceptor to fail any test that overrides the app profile when the app profile is specified
  • remove unused method
  • remove old user agent test hack

Change-Id: Iee431c1a5b979bef45785d08c41125945c76e6bb

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

- add ability to override the app profile for a test run
- ensure to skip the
- remove unused method
- remove old user agent test hack

Change-Id: Iee431c1a5b979bef45785d08c41125945c76e6bb
@igorbernstein2 igorbernstein2 requested review from a team as code owners October 10, 2024 22:15
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Oct 10, 2024
@cloud-java-bot cloud-java-bot requested a review from a team as a code owner October 10, 2024 22:19
Change-Id: Ib7a52c98c113479b5db603fc241f0e0e0c660670
@igorbernstein2 igorbernstein2 merged commit 05dc649 into main Oct 11, 2024
23 checks passed
@igorbernstein2 igorbernstein2 deleted the td-test branch October 11, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants