Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add internal "deadline remaining" client side metric #2341 #2370

Merged

Conversation

djyau
Copy link
Contributor

@djyau djyau commented Oct 3, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

Copy link

conventional-commit-lint-gcf bot commented Oct 3, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 3, 2024
@djyau djyau force-pushed the feature-deadline-remaining-metric branch from 71fb476 to a336fa4 Compare October 16, 2024 18:35
@djyau djyau marked this pull request as ready for review October 21, 2024 17:57
@djyau djyau requested review from a team as code owners October 21, 2024 17:57
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 28, 2024
@mutianf
Copy link
Contributor

mutianf commented Nov 4, 2024

/gcbrun

@mutianf
Copy link
Contributor

mutianf commented Nov 6, 2024

/gcbrun

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Nov 6, 2024
@mutianf
Copy link
Contributor

mutianf commented Nov 6, 2024

/gcbrun

@mutianf
Copy link
Contributor

mutianf commented Nov 6, 2024

/gcbrun

@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 6, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 75d4105 into googleapis:main Nov 6, 2024
20 of 21 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants