-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add internal "deadline remaining" client side metric #2341 #2370
Merged
gcf-merge-on-green
merged 42 commits into
googleapis:main
from
djyau:feature-deadline-remaining-metric
Nov 6, 2024
Merged
feat: add internal "deadline remaining" client side metric #2341 #2370
gcf-merge-on-green
merged 42 commits into
googleapis:main
from
djyau:feature-deadline-remaining-metric
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
size: s
Pull request size is small.
api: bigtable
Issues related to the googleapis/java-bigtable API.
size: m
Pull request size is medium.
and removed
size: s
Pull request size is small.
labels
Oct 3, 2024
djyau
force-pushed
the
feature-deadline-remaining-metric
branch
from
October 16, 2024 18:35
71fb476
to
a336fa4
Compare
mutianf
requested changes
Oct 21, 2024
...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracer.java
Outdated
Show resolved
Hide resolved
product-auto-label
bot
added
size: l
Pull request size is large.
and removed
size: m
Pull request size is medium.
labels
Oct 28, 2024
mutianf
approved these changes
Nov 4, 2024
/gcbrun |
/gcbrun |
product-auto-label
bot
added
size: m
Pull request size is medium.
and removed
size: l
Pull request size is large.
labels
Nov 6, 2024
/gcbrun |
mutianf
approved these changes
Nov 6, 2024
mutianf
requested changes
Nov 6, 2024
...ain/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableTracerStreamingCallable.java
Show resolved
Hide resolved
...rc/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableTracerUnaryCallable.java
Show resolved
Hide resolved
mutianf
reviewed
Nov 6, 2024
...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracer.java
Outdated
Show resolved
Hide resolved
mutianf
reviewed
Nov 6, 2024
...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracer.java
Outdated
Show resolved
Hide resolved
mutianf
approved these changes
Nov 6, 2024
/gcbrun |
mutianf
added
automerge
Merge the pull request once unit tests and other checks pass.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Nov 6, 2024
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 6, 2024
gcf-merge-on-green
bot
merged commit Nov 6, 2024
75d4105
into
googleapis:main
20 of 21 checks passed
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigtable
Issues related to the googleapis/java-bigtable API.
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.