Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rough sketch of optimizing away trailers #2352

Closed
wants to merge 7 commits into from
Closed

rough sketch of optimizing away trailers #2352

wants to merge 7 commits into from

Conversation

igorbernstein2
Copy link
Contributor

Change-Id: Ibe6afdf52b246dcd71f0f689ee1353a52e11a2cb

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Sep 23, 2024
@igorbernstein2
test: clean up CookieHolderTest
67e5899 
- stop returning protos to trigger headers
- fix thread safety for variables that are accessed by multiple threads

Change-Id: Ib34440d2ffeddcb5611b5e1cee183004bafc9449
@igorbernstein2
missing import
5c3bde3 
Change-Id: Ied61bc081c3cc0220fd96051aabd1849cbffd10f
@igorbernstein2
one more
79c5eae 
Change-Id: Ibf2f4ad8bea038390b1ddf099c3061f0d9b02495
@igorbernstein2
fix broken test
be7e931 
Change-Id: I63a6e54829ef5ea2db8d3b3b2db0afdc89cc1248
@igorbernstein2
make it consistent with other tests
a08a67b 
Change-Id: I2296b1cb7f52895a59e6b4fe5586d07c0dfd97a2
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 3, 2024
@igorbernstein2
wip
ca794e2 
Change-Id: Icd88367491120c32045ff11bf7b89cdcc0ea8b04
@igorbernstein2
wip
27a0a6f 
Change-Id: I1a182705d1990c3189d7c24a4248d5ae8b520db5
@igorbernstein2
Copy link
Contributor Author

Closing in favor of #2404

@igorbernstein2 igorbernstein2 deleted the skip-trailers branch December 17, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@igorbernstein2