-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update generation configuration at Mon Sep 16 02:26:47 UTC 2024 #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
Pull request size is extra small.
api: bigtable
Issues related to the googleapis/java-bigtable API.
labels
Sep 6, 2024
product-auto-label
bot
added
size: m
Pull request size is medium.
and removed
size: xs
Pull request size is extra small.
labels
Sep 6, 2024
Warning: This pull request is touching the following templated files:
|
JoeWang1127
reviewed
Sep 6, 2024
"excluded_poms": "google-cloud-bigtable-bom", | ||
"recommended_package": "com.google.cloud.bigtable" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diegomarquezp do we need to keep this value?
cloud-java-bot
changed the title
chore: Update generation configuration at Fri Sep 6 15:18:33 UTC 2024
chore: Update generation configuration at Sat Sep 7 02:18:55 UTC 2024
Sep 7, 2024
cloud-java-bot
changed the title
chore: Update generation configuration at Sat Sep 7 02:18:55 UTC 2024
chore: Update generation configuration at Sun Sep 8 02:24:26 UTC 2024
Sep 8, 2024
cloud-java-bot
changed the title
chore: Update generation configuration at Sun Sep 8 02:24:26 UTC 2024
chore: Update generation configuration at Tue Sep 10 02:21:43 UTC 2024
Sep 10, 2024
cloud-java-bot
changed the title
chore: Update generation configuration at Tue Sep 10 02:21:43 UTC 2024
chore: Update generation configuration at Tue Sep 10 19:31:11 UTC 2024
Sep 10, 2024
cloud-java-bot
changed the title
chore: Update generation configuration at Tue Sep 10 19:31:11 UTC 2024
chore: Update generation configuration at Wed Sep 11 02:20:51 UTC 2024
Sep 11, 2024
product-auto-label
bot
added
size: xl
Pull request size is extra large.
and removed
size: m
Pull request size is medium.
labels
Sep 11, 2024
cloud-java-bot
changed the title
chore: Update generation configuration at Wed Sep 11 02:20:51 UTC 2024
chore: Update generation configuration at Thu Sep 12 02:21:25 UTC 2024
Sep 12, 2024
cloud-java-bot
changed the title
chore: Update generation configuration at Thu Sep 12 02:21:25 UTC 2024
chore: Update generation configuration at Fri Sep 13 02:22:02 UTC 2024
Sep 13, 2024
cloud-java-bot
changed the title
chore: Update generation configuration at Fri Sep 13 02:22:02 UTC 2024
chore: Update generation configuration at Sat Sep 14 02:20:20 UTC 2024
Sep 14, 2024
cloud-java-bot
changed the title
chore: Update generation configuration at Sat Sep 14 02:20:20 UTC 2024
chore: Update generation configuration at Mon Sep 16 02:26:47 UTC 2024
Sep 16, 2024
igorbernstein2
approved these changes
Sep 16, 2024
JoeWang1127
added a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Sep 16, 2024
In this PR: - Do not exit if there's no code change. Context: we found an issue in bigtable (googleapis/java-bigtable#2336) such that PR description is overwritten by subsequent commit due to config updates. However, the generation associated with that [commit](googleapis/java-bigtable@b6e7e1d) didn't have code change (because the code change is already committed) and exit early so the PR description is not changed back.
ldetmer
pushed a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Sep 17, 2024
In this PR: - Do not exit if there's no code change. Context: we found an issue in bigtable (googleapis/java-bigtable#2336) such that PR description is overwritten by subsequent commit due to config updates. However, the generation associated with that [commit](googleapis/java-bigtable@b6e7e1d) didn't have code change (because the code change is already committed) and exit early so the PR description is not changed back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigtable
Issues related to the googleapis/java-bigtable API.
size: xl
Pull request size is extra large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Update generation configuration at Mon Sep 16 02:26:47 UTC 2024