Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for awaiting Data Boost #2329

Merged
merged 27 commits into from
Sep 16, 2024
Merged

feat: add support for awaiting Data Boost #2329

merged 27 commits into from
Sep 16, 2024

Conversation

djyau
Copy link
Contributor

@djyau djyau commented Aug 30, 2024 •
edited
Loading

Change-Id: I7ae07cc4f13e8ffe9ea4a55fb407eae1d64f8547

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@djyau
Introduce ConsistencyParams model
1617301 
Change-Id: I7ae07cc4f13e8ffe9ea4a55fb407eae1d64f8547
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Aug 30, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Aug 30, 2024
@djyau djyau changed the title Add support for awaiting Data Boos Add support for awaiting Data Boost Aug 30, 2024
@djyau
Create AwaitConsistencyCallable, a delegate for AwaitReplicationCallable
54e6540 
Change-Id: I16d7c69b4e1b9153f93e83f7f846d6c172aae8a6
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: s Pull request size is small. labels Sep 4, 2024
igorbernstein2
igorbernstein2 requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, please add an integration test

...loud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/ConsistencyParams.java Outdated Show resolved Hide resolved
...loud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/ConsistencyParams.java Outdated Show resolved Hide resolved
...bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/AwaitConsistencyCallable.java Outdated Show resolved Hide resolved
...bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/AwaitReplicationCallable.java Show resolved Hide resolved
djyau added 3 commits September 4, 2024 11:57
@djyau
Address some PR comments
d1b4320 
Change-Id: Icdf94f2f6a13f55d2c9204774d4ebbac5aa6a8b3
@djyau
Remove unused imports from AwaitReplicationCallable
febfb02 
Change-Id: Ia4861f1a5796061ca86844c67c68f54711fdbb94
@djyau
Plumb the Consistency callable through to some places, add some tests
84a2422 
Change-Id: Ibe60e2a1044933af1008c0cd1b84f757dd6867a8
@djyau
Add integration test
0f1faec 
Change-Id: Ie3b2b2983ca585cb1d6a2cdb8b18b55e81205759
djyau added 10 commits September 6, 2024 15:35
@djyau
Rework the ConsistencyRequest model, plumb through RequestContext to …
20f7809 
…BigtableTableAdminClient

Change-Id: I840282587d3d6cb4150dfbdd568c347dc32a732d
@djyau
Fix imports
2c47294 
Change-Id: Ic7588b3d04877a56089c23036d6df73a5c9b0cd5
@djyau
Fix more imports, fix some tests
ce0a439 
Change-Id: I2723fd67bd301a4eb3aeae80d91fa663cdd6ab01
@djyau
Rename some things
0327038 
Change-Id: Ie1bc8478c418d49b0c2e014edbeb6f56b56b0dd1
@djyau
Add tests for ConsistencyRequest model
c7fbb27 
Change-Id: I3548b7aa673be5a92cd4c180e3edb8649657811c
@djyau
Add newline
c8ff829 
Change-Id: Icdd22ce2857e5b4316c6fa3f0e139ea9de825178
@djyau
Fix broken test
f57b84d 
Change-Id: Idbd7c0f10ebe575d104ab7ac46a3a1e347e35fe8
@djyau
Make request context a final variable in test
86f6d8a 
Change-Id: I81f2a25fe4493021bab150ab0af65d7318ba2399
@djyau
Get test working using correct expectations
916535f 
Change-Id: Ie34d5171bd7a472fc695d603849e260054aedfbd
@djyau
Add a couple of tests for AwaitReplicationCallable
119ba23 
Change-Id: I70014db2c0a1d4e74c23b18de7ef591bc70cda2a
@igorbernstein2 igorbernstein2 changed the title Add support for awaiting Data Boost feat: add support for awaiting Data Boost Sep 9, 2024
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner September 9, 2024 18:49
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Sep 10, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 10, 2024
@djyau
Add license header to ConsistencyRequestTest
e263edd 
Change-Id: I733d2f8c082647ad32b72b04b218cd5ba79d2377
@djyau
Merge branch 'feature-await-data-boost-2' of https://github.com/djyau…
5dbc61a 
…/java-bigtable into feature-await-data-boost-2

Change-Id: I51fdac4701e85acd01045cf14f363cae428cc210
@gcf-merge-on-green GCF Merge on Green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 11, 2024
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Sep 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 11, 2024
@djyau
Add EnhancedBigtableTableAdminStub to clirr-ignored-differences
f628eb6 
Change-Id: I7eefeda777305dd3d7c5664097bda87ac63daa72
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 11, 2024
@igorbernstein2 igorbernstein2 mentioned this pull request Sep 11, 2024
Closed
6 tasks
@djyau
Fix IT tests, skip data boost one for now until we run it concurrently
3614dca 
Change-Id: I764190b0f91614753080e0a96e7e11e3dfb1fde0
@gcf-merge-on-green GCF Merge on Green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 12, 2024
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2024
@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Sep 13, 2024
@djyau
Run autoformatter
1240b3c 
Change-Id: Iba4671e4781f1b333279a2410563869f53b284d5
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2024
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 14, 2024
@igorbernstein2 igorbernstein2 merged commit 8556574 into googleapis:main Sep 16, 2024
19 of 21 checks passed
@release-please release-please bot mentioned this pull request Sep 13, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 16, 2024
@release-please
chore(main): release 2.44.0 (#2338)
0cd621e 
🤖 I have created a release *beep* *boop*
---


## [2.44.0](https://togithub.com/googleapis/java-bigtable/compare/v2.43.0...v2.44.0) (2024-09-16)


### Features

* Add APIs to enable hot backups ([#2313](https://togithub.com/googleapis/java-bigtable/issues/2313)) ([6d004cd](https://togithub.com/googleapis/java-bigtable/commit/6d004cd0809d02eeff05d5e90faf5e145f13d11e))
* Add support for awaiting Data Boost ([#2329](https://togithub.com/googleapis/java-bigtable/issues/2329)) ([8556574](https://togithub.com/googleapis/java-bigtable/commit/85565742645537d1b55a1a52521d2ccf44b4d00c))


### Dependencies

* Update shared dependencies ([#2337](https://togithub.com/googleapis/java-bigtable/issues/2337)) ([dc65bd5](https://togithub.com/googleapis/java-bigtable/commit/dc65bd5a39cfe0c25a6b955f9f4d9367df334211))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djyau @igorbernstein2 @yoshi-kokoro