Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove native image sample in favor of sample hosted in google-cloud-java #2273

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

mpeddada1
Copy link
Contributor

This PR removes the redundant, library-specific bigtable native image sample in favor of a single sample maintained in https://github.com/googleapis/google-cloud-java/tree/main/java-samples/native-image-sample

Documented externally in https://cloud.google.com/java/docs/compile-native-images#whats_next

@mpeddada1 mpeddada1 requested review from a team as code owners July 3, 2024 18:36
Copy link

snippet-bot bot commented Jul 3, 2024

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link

Warning: This pull request is touching the following templated files:

  • samples/pom.xml

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples. labels Jul 3, 2024
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
@igorbernstein2 igorbernstein2 merged commit 78a19f0 into main Aug 27, 2024
23 of 24 checks passed
@igorbernstein2 igorbernstein2 deleted the remove-native-image-sample branch August 27, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants