chore: update contributing doc #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
the
api: bigtable
kolea2
reviewed
Sep 28, 2023
| @@ -3,6 +3,7 @@ Thank you for opening a Pull Request! Before submitting your PR, there are a few | |||
| - [ ] Ensure the tests and linter pass | |||
| - [ ] Code coverage does not decrease (if any source code was changed) | |||
| - [ ] Appropriate docs were updated (if necessary) | |||
| - [ ] Rollback plan is reviewed and LGTMed | |||
There was a problem hiding this comment.
Owlbot is going to revert this - you can add it to our excludes list: https://github.com/googleapis/java-bigtable/blob/main/owlbot.py#L97
igorbernstein2
approved these changes
Oct 4, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
mutianf
added
the
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.