address comments and add a test

googleapis · Oct 22, 2024 · 0fc4efe · 0fc4efe
1 parent 04409f7
commit 0fc4efe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/.../java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableCloudMonitoringExporter.java b/.../java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableCloudMonitoringExporter.java
@@ -203,6 +203,7 @@ private CompletableResultCode exportBigtableResourceMetrics(Collection<MetricDat
       return CompletableResultCode.ofSuccess();
     }
 
+    // List of timeseries by project id
     Map<String, List<TimeSeries>> bigtableTimeSeries;
     try {
       bigtableTimeSeries =

diff --git a/...e/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableExporterUtils.java b/...e/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BigtableExporterUtils.java
@@ -113,6 +113,7 @@ static String getProjectId(PointData pointData) {
 
   static Map<String, List<TimeSeries>> convertToBigtableTimeSeries(
       List<MetricData> collection, String taskId) {
+    // List of timeseries by project id
     Map<String, List<TimeSeries>> allTimeSeries = new HashMap<>();
 
     for (MetricData metricData : collection) {