Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [dataplex] A new field force is added to message .google.cloud.dataplex.v1.DeleteDataScanRequest #5902

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1220,7 +1220,7 @@ message UpdateEntryRequest {
// specified path. For example, to attach an aspect to a field that is
// specified by the `schema` aspect, the path should have the format
// `Schema.<field_name>`.
// * `<aspect_type_reference>*` - matches aspects of the given type for all
// * `<aspect_type_reference>@*` - matches aspects of the given type for all
// paths.
// * `*@path` - matches aspects of all types on the given path.
//
Expand Down Expand Up @@ -1356,6 +1356,8 @@ message SearchEntriesRequest {
];

// Required. The query against which entries in scope should be matched.
// The query syntax is defined in [Search syntax for Dataplex
// Catalog](https://cloud.google.com/dataplex/docs/search-syntax).
string query = 2 [(google.api.field_behavior) = REQUIRED];

// Optional. Number of results in the search page. If <=0, then defaults
Expand All @@ -1368,6 +1370,10 @@ message SearchEntriesRequest {
string page_token = 4 [(google.api.field_behavior) = OPTIONAL];

// Optional. Specifies the ordering of results.
// Supported values are:
// * `relevance` (default)
// * `last_modified_timestamp`
// * `last_modified_timestamp asc`
string order_by = 5 [(google.api.field_behavior) = OPTIONAL];

// Optional. The scope under which the search should be operating. It must
Expand Down Expand Up @@ -1452,9 +1458,9 @@ message ImportItem {
// aspect type and are attached directly to the entry.
// * `{aspect_type_reference}@{path}`: matches aspects that belong to the
// specified aspect type and path.
// * `{aspect_type_reference}@*`: matches aspects that belong to the specified
// aspect type for all paths.
//
// * `<aspect_type_reference>@*` : matches aspects of the given type for all
// paths.
// * `*@path` : matches aspects of all types on the given path.
// Replace `{aspect_type_reference}` with a reference to the aspect type, in
// the format
// `{project_id_or_number}.{location_id}.{aspect_type_id}`.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package google.cloud.dataplex.v1;
import "google/api/annotations.proto";
import "google/api/client.proto";
import "google/api/field_behavior.proto";
import "google/api/field_info.proto";
import "google/api/resource.proto";
import "google/cloud/dataplex/v1/data_discovery.proto";
import "google/cloud/dataplex/v1/data_profile.proto";
Expand Down Expand Up @@ -182,9 +183,9 @@ message UpdateDataScanRequest {
// Only fields specified in `update_mask` are updated.
DataScan data_scan = 1 [(google.api.field_behavior) = REQUIRED];

// Required. Mask of fields to update.
// Optional. Mask of fields to update.
google.protobuf.FieldMask update_mask = 2
[(google.api.field_behavior) = REQUIRED];
[(google.api.field_behavior) = OPTIONAL];

// Optional. Only validate the request, but do not perform mutations.
// The default is `false`.
Expand All @@ -203,6 +204,11 @@ message DeleteDataScanRequest {
type: "dataplex.googleapis.com/DataScan"
}
];

// Optional. If set to true, any child resources of this data scan will also
// be deleted. (Otherwise, the request will only work if the data scan has no
// child resources.)
bool force = 2 [(google.api.field_behavior) = OPTIONAL];
}

// Get dataScan request.
Expand Down Expand Up @@ -443,26 +449,34 @@ message DataScan {

// Status of the data scan execution.
message ExecutionStatus {
// The time when the latest DataScanJob started.
google.protobuf.Timestamp latest_job_start_time = 4;
// Optional. The time when the latest DataScanJob started.
google.protobuf.Timestamp latest_job_start_time = 4
[(google.api.field_behavior) = OPTIONAL];

// The time when the latest DataScanJob ended.
google.protobuf.Timestamp latest_job_end_time = 5;
// Optional. The time when the latest DataScanJob ended.
google.protobuf.Timestamp latest_job_end_time = 5
[(google.api.field_behavior) = OPTIONAL];

// Optional. The time when the DataScanJob execution was created.
google.protobuf.Timestamp latest_job_create_time = 6
[(google.api.field_behavior) = OPTIONAL];
}

// Output only. The relative resource name of the scan, of the form:
// `projects/{project}/locations/{location_id}/dataScans/{datascan_id}`,
// Output only. Identifier. The relative resource name of the scan, of the
// form: `projects/{project}/locations/{location_id}/dataScans/{datascan_id}`,
// where `project` refers to a *project_id* or *project_number* and
// `location_id` refers to a GCP region.
string name = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
string name = 1 [
(google.api.field_behavior) = OUTPUT_ONLY,
(google.api.field_behavior) = IDENTIFIER
];

// Output only. System generated globally unique ID for the scan. This ID will
// be different if the scan is deleted and re-created with the same name.
string uid = 2 [(google.api.field_behavior) = OUTPUT_ONLY];
string uid = 2 [
(google.api.field_info).format = UUID4,
(google.api.field_behavior) = OUTPUT_ONLY
];

// Optional. Description of the scan.
//
Expand Down Expand Up @@ -565,14 +579,21 @@ message DataScanJob {
PENDING = 7;
}

// Output only. The relative resource name of the DataScanJob, of the form:
// Output only. Identifier. The relative resource name of the DataScanJob, of
// the form:
// `projects/{project}/locations/{location_id}/dataScans/{datascan_id}/jobs/{job_id}`,
// where `project` refers to a *project_id* or *project_number* and
// `location_id` refers to a GCP region.
string name = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
string name = 1 [
(google.api.field_behavior) = OUTPUT_ONLY,
(google.api.field_behavior) = IDENTIFIER
];

// Output only. System generated globally unique ID for the DataScanJob.
string uid = 2 [(google.api.field_behavior) = OUTPUT_ONLY];
string uid = 2 [
(google.api.field_info).format = UUID4,
(google.api.field_behavior) = OUTPUT_ONLY
];

// Output only. The time when the DataScanJob was created.
google.protobuf.Timestamp create_time = 8
Expand Down
6 changes: 6 additions & 0 deletions packages/google-cloud-dataplex/protos/protos.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 25 additions & 1 deletion packages/google-cloud-dataplex/protos/protos.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 20 additions & 5 deletions packages/google-cloud-dataplex/protos/protos.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ function main(name, query) {
// const name = 'abc123'
/**
* Required. The query against which entries in scope should be matched.
* The query syntax is defined in Search syntax for Dataplex
* Catalog (https://cloud.google.com/dataplex/docs/search-syntax).
*/
// const query = 'abc123'
/**
Expand All @@ -50,6 +52,10 @@ function main(name, query) {
// const pageToken = 'abc123'
/**
* Optional. Specifies the ordering of results.
* Supported values are:
* * `relevance` (default)
* * `last_modified_timestamp`
* * `last_modified_timestamp asc`
*/
// const orderBy = 'abc123'
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function main(entry) {
* specified path. For example, to attach an aspect to a field that is
* specified by the `schema` aspect, the path should have the format
* `Schema.<field_name>`.
* * `<aspect_type_reference>*` - matches aspects of the given type for all
* * `<aspect_type_reference>@*` - matches aspects of the given type for all
* paths.
* * `*@path` - matches aspects of all types on the given path.
* The service will not remove existing aspects matching the syntax unless
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ function main(name) {
* `location_id` refers to a GCP region.
*/
// const name = 'abc123'
/**
* Optional. If set to true, any child resources of this data scan will also
* be deleted. (Otherwise, the request will only work if the data scan has no
* child resources.)
*/
// const force = true

// Imports the Dataplex library
const {DataScanServiceClient} = require('@google-cloud/dataplex').v1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

'use strict';

function main(dataScan, updateMask) {
function main(dataScan) {
// [START dataplex_v1_generated_DataScanService_UpdateDataScan_async]
/**
* This snippet has been automatically generated and should be regarded as a code template only.
Expand All @@ -34,7 +34,7 @@ function main(dataScan, updateMask) {
*/
// const dataScan = {}
/**
* Required. Mask of fields to update.
* Optional. Mask of fields to update.
*/
// const updateMask = {}
/**
Expand All @@ -53,7 +53,6 @@ function main(dataScan, updateMask) {
// Construct request
const request = {
dataScan,
updateMask,
};

// Run request
Expand Down
Loading
Loading