-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: [backupdr] Remove visibility of unneeded TestIamPermissions RPC #5713
Open
gcf-owl-bot
wants to merge
7
commits into
main
Choose a base branch
from
owl-bot-copy-packages-google-cloud-backupdr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Add backupplan proto feat: Add backupplanassociation proto feat: Add backupvault_ba proto feat: Add backupvault_gce proto docs: A comment for field `oauth2_client_id` in message `.google.cloud.backupdr.v1.ManagementServer` is changed docs: A comment for field `parent` in message `.google.cloud.backupdr.v1.ListManagementServersRequest` is changed docs: A comment for field `management_servers` in message `.google.cloud.backupdr.v1.ListManagementServersResponse` is changed docs: A comment for field `name` in message `.google.cloud.backupdr.v1.GetManagementServerRequest` is changed docs: A comment for field `parent` in message `.google.cloud.backupdr.v1.CreateManagementServerRequest` is changed docs: A comment for field `requested_cancellation` in message `.google.cloud.backupdr.v1.OperationMetadata` is changed PiperOrigin-RevId: 678800741 Source-Link: googleapis/googleapis@d36e288 Source-Link: googleapis/googleapis-gen@fba9d22 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiJmYmE5ZDIyNWI0M2RjZjczNjEwMDY0OTE4MTA0ODVjZGYxYjU3Y2RiIn0=
/gcbrun |
gcf-owl-bot
bot
requested review from
yoshi-approver and
a team
as code owners
September 26, 2024 00:12
/gcbrun |
…/github.com/googleapis/google-cloud-node into owl-bot-copy-packages-google-cloud-backupdr
/gcbrun |
Note to reviewers: A change in this PR is being evaluated for rollback. I can't add |
danielbankhead
approved these changes
Sep 27, 2024
/gcbrun |
danielbankhead
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Sep 27, 2024
fix!: Remove visibility of unneeded InitiateBackup RPC fix!: Remove visibility of unneeded AbandonBackup RPC fix!: Remove visibility of unneeded FinalizeBackup RPC fix!: Remove visibility of unneeded RemoveDataSource RPC fix!: Remove visibility of unneeded SetInternalStatus RPC PiperOrigin-RevId: 683196317 Source-Link: googleapis/googleapis@c532f35 Source-Link: googleapis/googleapis-gen@fd43f57 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiJmZDQzZjU3MzNiMDAyMzU4ZmE2Nzk2MjNmNjA5OWFhZmI2NjYwYzhlIn0=
gcf-owl-bot
bot
changed the title
feat: [backupdr] Client library for the backupvault api is added
fix!: [backupdr] Remove visibility of unneeded TestIamPermissions RPC
Oct 7, 2024
/gcbrun |
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
owl-bot-copy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix!: Remove visibility of unneeded InitiateBackup RPC
fix!: Remove visibility of unneeded AbandonBackup RPC
fix!: Remove visibility of unneeded FinalizeBackup RPC
fix!: Remove visibility of unneeded RemoveDataSource RPC
fix!: Remove visibility of unneeded SetInternalStatus RPC
PiperOrigin-RevId: 683196317
Source-Link: googleapis/googleapis@c532f35
Source-Link: https://github.com/googleapis/googleapis-gen/commit/fd43f5733b002358fa679623f6099aafb6660c8e
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiJmZDQzZjU3MzNiMDAyMzU4ZmE2Nzk2MjNmNjA5OWFhZmI2NjYwYzhlIn0=
BEGIN_NESTED_COMMIT
feat: [backupdr] Client library for the backupvault api is added
feat: Add backupplan proto
feat: Add backupplanassociation proto
feat: Add backupvault_ba proto
feat: Add backupvault_gce proto
docs: A comment for field
oauth2_client_id
in message.google.cloud.backupdr.v1.ManagementServer
is changeddocs: A comment for field
parent
in message.google.cloud.backupdr.v1.ListManagementServersRequest
is changeddocs: A comment for field
management_servers
in message.google.cloud.backupdr.v1.ListManagementServersResponse
is changeddocs: A comment for field
name
in message.google.cloud.backupdr.v1.GetManagementServerRequest
is changeddocs: A comment for field
parent
in message.google.cloud.backupdr.v1.CreateManagementServerRequest
is changeddocs: A comment for field
requested_cancellation
in message.google.cloud.backupdr.v1.OperationMetadata
is changedPiperOrigin-RevId: 678800741
Source-Link: googleapis/googleapis@d36e288
Source-Link: https://github.com/googleapis/googleapis-gen/commit/fba9d225b43dcf7361006491810485cdf1b57cdb
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWJhY2t1cGRyLy5Pd2xCb3QueWFtbCIsImgiOiJmYmE5ZDIyNWI0M2RjZjczNjEwMDY0OTE4MTA0ODVjZGYxYjU3Y2RiIn0=
END_NESTED_COMMIT