fix: remove token_info call from token refresh path #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sai-sunder-s could we leave this in as a fallback? I am worried this will break certain use cases. |
clundin25
reviewed
Sep 16, 2024
| @@ -351,33 +350,6 @@ def with_universe_domain(self, universe_domain): | |||
| def _metric_header_for_usage(self): | |||
| return metrics.CRED_TYPE_USER | |||
|
|
|||
| def _set_account_from_access_token(self, request): | |||
There was a problem hiding this comment.
Could you alternatively perform this in the account property in case _account is not already set?
The code I am removing is not released yet. It was added in https://github.com/googleapis/google-auth-library-python/pull/1587/files#diff-1642b863da79afb2c93ba8091f011e12d0c9d50eca6b89ea5ac7e9509bf51647 |
clundin25
approved these changes
Sep 16, 2024
sai-sunder-s
force-pushed
the
errormsg
branch
from
fada1b0 to
2a38a51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A call to
token_infoendpoint is being made in critical path when refreshing access tokens. Removing that call and instead going to provide theaccountfrom user credential file.