Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump urllib3 from 1.26.12 to 1.26.17 in /.kokoro #1406

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Nov 3, 2023

Source-Link: googleapis/synthtool@bc07fd4
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:30470597773378105e239b59fce8eb27cc97375580d592699206d17d117143d0

Source-Link: googleapis/synthtool@bc07fd4
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:30470597773378105e239b59fce8eb27cc97375580d592699206d17d117143d0
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners November 3, 2023 01:00
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2023
@parthea parthea changed the title chore: update docfx minimum Python version chore(deps): bump urllib3 from 1.26.12 to 1.26.17 in /.kokoro Nov 3, 2023
@pquentin
Copy link

pquentin commented Nov 3, 2023

This library supports urllib3 2.0, I don't know what kokoro is, but I would suggest bumping the urllib3 version to 2.0.7 instead.

@parthea
Copy link
Contributor

parthea commented Nov 3, 2023

The files in .kokoro are used for testing and releasing. The source for this change is located here:
https://github.com/googleapis/synthtool/blob/bc07fd415c39853b382bcf8315f8eeacdf334055/synthtool/gcp/templates/python_library/.kokoro/requirements.txt#L470-L475

I've opened PR googleapis/synthtool#1892 to update urllib3 to 2.0.7. A PR in this repository should be opened automatically once PR googleapis/synthtool#1892 is merged.

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 7, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2023
@vchudnov-g
Copy link

Approved and merged googleapis/synthtool#1892. Waiting for the resulting PR in this repo.

@parthea parthea closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants