Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace cs and staticanalysis with reusable workflows #573

Merged
merged 7 commits into from
Aug 26, 2024
Merged

chore: replace cs and staticanalysis with reusable workflows #573

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ab510de
chore: replace cs and staticanalysis with reusable workflows
bshaffer Aug 16, 2024
2b40476
Apply suggestions from code review
bshaffer Aug 16, 2024
0b7fd38
Apply suggestions from code review
bshaffer Aug 16, 2024
24275b9
Update .github/workflows/tests.yml
bshaffer Aug 16, 2024
bca98eb
remove php-cs-fixer config
bshaffer Aug 20, 2024
63d8169
Merge branch 'reusable-workflow' of github.com:googleapis/google-auth…
bshaffer Aug 20, 2024
241c21e
Merge branch 'main' into reusable-workflow
bshaffer Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 4 additions & 24 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,31 +51,11 @@ jobs:
run: vendor/bin/phpunit

style:
runs-on: ubuntu-latest
name: PHP Style Check
steps:
- uses: actions/checkout@v4
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.2'
- name: Run Script
run: |
composer install
composer global require friendsofphp/php-cs-fixer:^3.0
~/.composer/vendor/bin/php-cs-fixer fix --dry-run --diff
uses: GoogleCloudPlatform/php-tools/.github/workflows/code-standards.yml@main

staticanalysis:
runs-on: ubuntu-latest
name: PHPStan Static Analysis
steps:
- uses: actions/checkout@v4
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.2'
- name: Run Script
run: |
composer install
composer global require phpstan/phpstan:^1.8
~/.composer/vendor/bin/phpstan analyse --autoload-file tests/phpstan-autoload.php
uses: GoogleCloudPlatform/php-tools/.github/workflows/code-standards.yml@main
bshaffer marked this conversation as resolved.
Show resolved Hide resolved
with:
autoload-file: tests/phpstan-autoload.php