Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop deprecated Item class #569

Conversation

artemkurylo
Copy link

Drop deprecated Item class.

This class isn't used anymore and was deprecated along with drop of PHP 7.4. As a destructive example of it's presence, one of the projects that I'm working on tries to load every file from vendor directory into the memory and this class breaks it, because it doesn't comply with CacheItemInterface interface (missing return types, which results in a fatal error).

@artemkurylo artemkurylo requested a review from a team as a code owner July 17, 2024 15:48
Copy link

google-cla bot commented Jul 17, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bshaffer
Copy link
Contributor

bshaffer commented Jul 17, 2024

As long as we support psr/cache: ^2.0, we need these item classes

"psr/cache": "^2.0||^3.0"

@artemkurylo
Copy link
Author

Ah, didn't notice it, makes sense. Thanks for taking a look.
Then we can close this one until team decides to drop the support for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants