Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop support for PHP 8.0 #532

Merged
merged 4 commits into from
Oct 3, 2024
Merged

chore: drop support for PHP 8.0 #532

merged 4 commits into from
Oct 3, 2024

Conversation

bshaffer
Copy link
Contributor

  • Remove support for Google\Auth\Cache\Item, which is no longer compatible with these dependencies
  • Drop compatibility for PHP 7.4 and 8.0
  • Drop compatibility with guzzlehttp/guzzle v6, and psr/cache v1

@bshaffer bshaffer requested a review from a team as a code owner February 13, 2024 16:11
@vishwarajanand
Copy link
Contributor

I added some fixes as part of d6eba00 to fix the style errors

vishwarajanand
vishwarajanand approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes in this PR are good to go.
I don't understand when tests.yml specifically removed php<=v8.0 why does the PR still mark their tests as expected to be reported (and in-fact required).

@bshaffer
Copy link
Contributor Author

why does the PR still mark their tests as expected to be reported (and in-fact required).

Because this is managed in the GitHub repo settings (the yaml file syncs those settings, but only once they're in main). So they need to be changed there first.

@bshaffer bshaffer added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 20, 2024
@bshaffer bshaffer mentioned this pull request Feb 20, 2024
Merged
@bshaffer bshaffer changed the title chore: drop support for PHP 7.4 and PHP 8.0 chore: drop support for PHP 8.0 Feb 20, 2024
@bshaffer
Copy link
Contributor Author

I've added the Do Not Merge label because we are going to postpone dropping support for PHP 8.0 until May.

We will drop support for PHP 7.4 on Feb 29th. See #538

@bshaffer bshaffer removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 27, 2024
@bshaffer bshaffer merged commit 257ba33 into main Oct 3, 2024
13 checks passed
@bshaffer bshaffer deleted the drop-php80 branch October 3, 2024 15:43
@bshaffer bshaffer mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwarajanand vishwarajanand vishwarajanand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bshaffer @vishwarajanand