Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: universe domain for Iam #531

Merged
merged 4 commits into from
Feb 20, 2024
Merged

feat: universe domain for Iam #531

merged 4 commits into from
Feb 20, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Feb 13, 2024 •
edited
Loading

  • Add "universe domain" support for Iam
  • Ensure IamSignerTrait passes in the universe domain when it can

@bshaffer bshaffer requested a review from a team as a code owner February 13, 2024 15:42
vishwarajanand
vishwarajanand approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how to test this in setup. And I don't see this being used a lot of references.
Looks like a good to have feature hence approving.

@bshaffer bshaffer merged commit b905a56 into main Feb 20, 2024
13 checks passed
@bshaffer bshaffer deleted the universe-domain-for-iam branch February 20, 2024 15:16
@release-please release-please bot mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwarajanand vishwarajanand vishwarajanand approved these changes

@TimurSadykov TimurSadykov Awaiting requested review from TimurSadykov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bshaffer @vishwarajanand