Skip to content

Commit

Permalink
Change the client ID field to represent a Gapic Client
Browse files Browse the repository at this point in the history
  • Loading branch information
Hectorhammett committed Dec 5, 2024
1 parent 1a7523b commit 876f14a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions src/ApplicationDefaultCredentials.php
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,8 @@ public static function getIdTokenCredentials(
/**
* Returns a StdOutLogger instance
*
* @internal
*
* @return null|LoggerInterface
*/
public static function getDefaultLogger(): null|LoggerInterface
Expand Down
6 changes: 3 additions & 3 deletions src/HttpHandler/Guzzle6HttpHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public function __invoke(RequestInterface $request, array $options = [])
$requestEvent->payload = $request->getBody()->getContents();
$requestEvent->retryAttempt = $options['retryAttempt'] ?? null;
$requestEvent->serviceName = $options['serviceName'] ?? null;
$requestEvent->clientId = spl_object_id($this->client);
$requestEvent->clientId = $options['clientId'];
$requestEvent->requestId = $options['requestId'] ?? spl_object_id($request);

$this->logRequest($requestEvent);
Expand Down Expand Up @@ -111,8 +111,8 @@ public function async(RequestInterface $request, array $options = [])
$requestEvent->payload = $request->getBody()->getContents();
$requestEvent->retryAttempt = $options['retryAttempt'] ?? null;
$requestEvent->serviceName = $options['serviceName'] ?? null;
$requestEvent->clientId = spl_object_id($this->client);
$requestEvent->requestId = spl_object_id($request);
$requestEvent->clientId = $options['clientId'];
$requestEvent->requestId = $options['requestId'] ?? spl_object_id($request);

$this->logRequest($requestEvent);
}
Expand Down

0 comments on commit 876f14a

Please sign in to comment.