add impersonate id token metric test

googleapis · Oct 5, 2024 · 244724f · 244724f
1 parent bdf24f8
commit 244724f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/src/Credentials/ImpersonatedServiceAccountCredentials.php b/src/Credentials/ImpersonatedServiceAccountCredentials.php
@@ -186,7 +186,7 @@ public function fetchAuthToken(callable $httpHandler = null)
             'Content-Type' => 'application/json',
             'Cache-Control' => 'no-store',
             'Authorization' => sprintf('Bearer %s', $authToken['access_token'] ?? $authToken['id_token']),
-        ], 'at');
+        ], $this->isIdTokenRequest() ? 'it' : 'at');
 
         $body = $this->isIdTokenRequest()
             ? [

diff --git a/tests/ObservabilityMetricsTest.php b/tests/ObservabilityMetricsTest.php
@@ -117,10 +117,6 @@ public function testServiceAccountJwtAccessCredentials()
         );
     }
 
-    /**
-     * ImpersonatedServiceAccountCredentials haven't enabled identity token support hence
-     * they don't have 'auth-request-type/it' observability metric header check.
-     */
     public function testImpersonatedServiceAccountCredentials()
     {
         $keyFile = __DIR__ . '/fixtures5/.config/gcloud/application_default_credentials.json';
@@ -135,6 +131,20 @@ public function testImpersonatedServiceAccountCredentials()
         $this->assertUpdateMetadata($impersonatedCred, $handler, 'imp', $handlerCalled);
     }
 
+    public function testImpersonatedServiceAccountCredentialsWithIdTokens()
+    {
+        $keyFile = __DIR__ . '/fixtures5/.config/gcloud/application_default_credentials.json';
+        $handlerCalled = false;
+        $responseFromIam = json_encode(['token' => '1/abdef1234567890']);
+        $handler = getHandler([
+            $this->getExpectedRequest('imp', 'auth-request-type/at', $handlerCalled, $this->jsonTokens),
+            $this->getExpectedRequest('imp', 'auth-request-type/it', $handlerCalled, $responseFromIam),
+        ]);
+
+        $impersonatedCred = new ImpersonatedServiceAccountCredentials(null, $keyFile, 'test-target-audience');
+        $this->assertUpdateMetadata($impersonatedCred, $handler, 'imp', $handlerCalled);
+    }
+
     /**
      * UserRefreshCredentials haven't enabled identity token support hence
      * they don't have 'auth-request-type/it' observability metric header check.