[pointer][transmute] Support generic TransmuteFrom #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2024
joshlf
force-pushed
the
I25973ea67f59671329a920dd39183c1348942a1a
branch
2 times, most recently
from
4887e03
to
c6f8751
Compare
joshlf
force-pushed
the
I1ac2ae177a235083e33b09fc848423220d3da042
branch
from
33fc89f
to
48f1450
Compare
joshlf
force-pushed
the
I25973ea67f59671329a920dd39183c1348942a1a
branch
from
c6f8751
to
f3a5e25
Compare
This commit replaces the `TransparentWrapper` trait with a more generic, bidirectional `TransmuteFrom<T>` trait. `U: TransmuteFrom<T>` indicates that `T` and `U` have the same sizes and that `T` can be transmuted into `U` given certain alignment and validity invariant mappings. Makes progress on #1122 gherrit-pr-id: I25973ea67f59671329a920dd39183c1348942a1a
joshlf
force-pushed
the
I25973ea67f59671329a920dd39183c1348942a1a
branch
from
f3a5e25
to
e8db1f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the
TransparentWrappertrait with a more generic,bidirectional
TransmuteFrom<T>trait.U: TransmuteFrom<T>indicatesthat
TandUhave the same sizes and thatTcan be transmuted intoUgiven certain alignment and validity invariant mappings.Makes progress on #1122
This PR is on branch ptr-overhaul-more-generic-issue-1945.