Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update ast for supporting generics #385

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aqaurius6666
Copy link

@aqaurius6666 aqaurius6666 commented Jul 10, 2023

This PR is a follow-up to reverted PR #360.

  • Add a testcase for Generic.

@google-cla
Copy link

google-cla bot commented Jul 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@aqaurius6666 aqaurius6666 reopened this Mar 11, 2024
@aqaurius6666
Copy link
Author

@toddtreece Could you help me review this PR 🙇

@osousa
Copy link

osousa commented Jul 3, 2024

@stytchiz it seems the test issue referenced here is solved, why not approve this PR and let us have fun with generics and wire? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants