Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Split ci coverage job #179

Merged
merged 4 commits into from
Dec 3, 2024
Merged

chore: Split ci coverage job #179

merged 4 commits into from
Dec 3, 2024

Conversation

koji-1009
Copy link
Contributor

ref #178

  • Separation of jobs to check coverage
  • Setting timeout-minutes
    • Set to exit when flutter run test fails

@koji-1009 koji-1009 changed the title Coverage job separation Coverage ci job separation Dec 2, 2024
@koji-1009 koji-1009 mentioned this pull request Dec 2, 2024
Open
@koji-1009 koji-1009 changed the title Coverage ci job separation Split ci coverage job Dec 2, 2024
@koji-1009 koji-1009 changed the title Split ci coverage job chore: Split ci coverage job Dec 2, 2024
jonasfj
jonasfj reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's bump the timeouts to 15 min

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@koji-1009 koji-1009 requested a review from jonasfj December 2, 2024 22:35
jonasfj
jonasfj approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@jonasfj jonasfj merged commit b2cdb85 into google:master Dec 3, 2024
14 checks passed
@koji-1009 koji-1009 deleted the ci/coverage branch December 3, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koji-1009 @jonasfj