Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in test.yml #167

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix typo in test.yml #167

merged 2 commits into from
Oct 23, 2024

Conversation

jonasfj
Copy link
Member

@jonasfj jonasfj commented Oct 23, 2024

Couldn't get the tests to run, so I just assumed it was a fluke. Only when I landed on master it was obvious that I had malformed YAML 🙈

@jonasfj jonasfj changed the title Update test.yml Fix typo in test.yml Oct 23, 2024
@jonasfj
Copy link
Member Author

jonasfj commented Oct 23, 2024

88.7% coverage is not bad!

Not bad at all.

I'm not actually sure we'll get much more coverage by collecting coverage from integration tests, etc.

We have:

  • Error cases that are not covered by testing -- this is probably worth returning to, once refactoring is done.
  • Unused functions, mostly harmless toString implementations, maybe some of them can go away. But let's review later.

Code coverage around 80% is really good. If eventually we can cover most of the error cases, I think we should be very happy.

Let's not focus too much on the number, and focus more on what code paths are uncovered.
(once we're done refactoring)

Copy link
Collaborator

@HamdaanAliQuatil HamdaanAliQuatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@HamdaanAliQuatil HamdaanAliQuatil merged commit c2a45d1 into master Oct 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants