Skip to content

Commit

Permalink
Disable chromedriver tests on macos (#155)
Browse files Browse the repository at this point in the history
This is effectively integration tests for Chrome on MacOS.
These tests shouldn't really be necessary, since we tests chrome
compatibility in multiple ways.

For unknown reasons these tests are unreliable on MacOS.
They were constantly timing out for no good reason.
  • Loading branch information
jonasfj authored Oct 11, 2024
1 parent 58bc71a commit f4de7c1
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,15 @@ jobs:
- run: flutter test --platform chrome
- run: flutter test integration_test/webcrypto_test.dart -d macos
working-directory: ./example
- uses: nanasess/setup-chromedriver@v2
- name: Run integration_test with chromedriver
working-directory: ./example
run: |
../tool/with-chromedriver.sh flutter drive \
--driver=test_driver/integration_test.dart \
--target=integration_test/webcrypto_test.dart \
-d chrome
# TODO: Enable chromdriver testing on MacOS when it works reliably
#- uses: nanasess/setup-chromedriver@v2
#- name: Run integration_test with chromedriver
# working-directory: ./example
# run: |
# ../tool/with-chromedriver.sh flutter drive \
# --driver=test_driver/integration_test.dart \
# --target=integration_test/webcrypto_test.dart \
# -d chrome
- run: flutter pub run test -p vm,chrome # TODO: Enable firefox if it works
windows:
name: webcrypto on Windows desktop / Chrome / Firefox
Expand Down

0 comments on commit f4de7c1

Please sign in to comment.