Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust segvit compatibility + new dataset. #1183

Open
wants to merge 170 commits into
base: main
Choose a base branch
from

Conversation

ekellbuch
Copy link
Contributor

This commit makes the code in robust_segvit compatible externally and adds config files to experiment with a benchmark for open set recognition in image segmentation, namely the street hazards dataset from https://arxiv.org/abs/1911.11132.

ekellbuch and others added 30 commits November 11, 2021 15:05
… update segmenter_test to test different classifiers
…baselines into load_check

merging ub which now includes segmenter
@ekellbuch ekellbuch marked this pull request as ready for review November 3, 2022 19:52
# pytype: enable=wrong-arg-types

# free memory
del restored_params
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be deleted anyway when the function returns on the next line, so I don't think we need to explicitly delete it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

experimental/robust_segvit/uncertainty_metrics.py Outdated Show resolved Hide resolved
from uncertainty_metrics import SegmentationUncertaintyMetrics # local file import from experimental.robust_segvit


class UncertaintyMetricsTest(parameterized.TestCase):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about updating these tests instead of deleting them?


# TODO(kellybuchanan): add masking to ece metric in rm.
# updates on each host separately
ece_metric.update_state(e_batch['label'], probs, sample_weight=e_batch['batch_mask'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the comment in google-research/robustness_metrics#77, can we move the binary masking logic here such that we pass in a masked subset of labels and probs as needed without changing the ECE metric API?

ekellbuch and others added 26 commits November 7, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants