-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argo CD weak credential tester #502
base: master
Are you sure you want to change the base?
Argo CD weak credential tester #502
Conversation
Hi @JamesFoxxx, thank you for your contribution. I'm noticing that the plugin is not working on my side, can you please check it? Feels like the fingerprint phase never ran. |
…the http client doesn't redirect in response of this status code
@leonardo-doyensec hii Also according to the last commit, it seems that tsunami doesn't redirect by default for the 307 redirect status code and It's weird because the http redirect is true by default. |
@leonardo-doyensec we should compile two separate gradle projects, one for weak credentials and one for the web fingerprint, and use both plugins when running the Tsunami scanner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @JamesFoxxx, thank you for your changes.
I confirm that the plugin is working correctly. You can find some issues to address down below.
...tectors/credentials/genericweakcredentialdetector/testers/argocd/ArgoCdCredentialTester.java
Show resolved
Hide resolved
...tectors/credentials/genericweakcredentialdetector/testers/argocd/ArgoCdCredentialTester.java
Outdated
Show resolved
Hide resolved
...tectors/credentials/genericweakcredentialdetector/testers/argocd/ArgoCdCredentialTester.java
Outdated
Show resolved
Hide resolved
...tectors/credentials/genericweakcredentialdetector/testers/argocd/ArgoCdCredentialTester.java
Outdated
Show resolved
Hide resolved
...tectors/credentials/genericweakcredentialdetector/testers/argocd/ArgoCdCredentialTester.java
Outdated
Show resolved
Hide resolved
...tectors/credentials/genericweakcredentialdetector/testers/argocd/ArgoCdCredentialTester.java
Outdated
Show resolved
Hide resolved
...tectors/credentials/genericweakcredentialdetector/testers/argocd/ArgoCdCredentialTester.java
Outdated
Show resolved
Hide resolved
...tectors/credentials/genericweakcredentialdetector/testers/argocd/ArgoCdCredentialTester.java
Outdated
Show resolved
Hide resolved
...ors/credentials/genericweakcredentialdetector/testers/argocd/ArgoCdCredentialTesterTest.java
Outdated
Show resolved
Hide resolved
LGTM - Approved Reviewer: Leonardo, Doyensec |
according to this setup: https://github.com/google/security-testbeds/pull/60/files