Add the fingerprint updater and .binproto for Apache Solr

[W0ngL1]

Hi @tooryx,

This PR is about #395.

The solr team started to build docker images from 8 years ago, the first version which has a official docker is 5.3.1, but versions from 5.3.1 to 5.5.0 cannot be launched using official examples due to missing files. So the actual fingerprint only covers versions 5.5.1(8 years ago) to 9.5.0(2024.01).

And the version 8.1.0 has only one alias for 8.1 in hub.docker.com, so there is an IF check for it in update.sh.

#408 was deleted by mistake, so I reopen one.

[lokiuox]

Hey @W0ngL1, thanks for your contribution!

I'm reviewing your plugin and I confirm it's working. I've added a few comments on little things that can be improved.

[lokiuox]

The file is missing the executable bit, please add it

[lokiuox]

I'm having issues with version 6.0.0, docker complains that the image file is in the incorrect format. Do you have the same issue?

[W0ngL1]

It doesn't look like it, I checked the temporary fingerprint file from the last run.

...
-rw-r--r-- 1 root root 259787  3月  8  2024 fingerprint.6.5.1.json
-rw-r--r-- 1 root root 275376  3月  8  2024 fingerprint.6.6.0.json
-rw-r--r-- 1 root root 290605  3月  8  2024 fingerprint.6.6.1.json
...

[W0ngL1]

Hi @lokiuox, feel free to review it.

[lokiuox]

Hey @W0ngL1, the fingerprinter seems fine, but there are still a few things to fix.

Besides the comments in the review, please also address these things:

• Set the executable bit on the update.sh file
• I see that there are a few old versions still missing for which there are images available, i.e. v5.3.x and v5.4.x. If possible please add them too.

[W0ngL1]

Hi @lokiuox,

I've updated version.txt. Versions 5.3.0/5.3.1/5.3.2/5.4.0/5.4.1 can be found in docker hub, but versions 5.3.1/5.4.0 are no longer allowed to be pulled.
I'll update .binproto file soon.

I don't understand what Set the executable bit on the update.sh file means, like chmod +x update.sh?

[lokiuox]

You can use this command to mark the file as executable: git update-index --chmod=+x update.sh.
If it doesn't work, try removing it and adding it again:

git update-index --chmod=-x update.sh
git update-index --chmod=+x update.sh

[W0ngL1]

You can use this command to mark the file as executable: git update-index --chmod=+x update.sh. If it doesn't work, try removing it and adding it again:

git update-index --chmod=-x update.sh
git update-index --chmod=+x update.sh

Copy that.

[W0ngL1]

Hi @lokiuox, I delete files and re-clone it, and update.sh has execution permission.

[lokiuox]

LGTM - Approved
@maoning you can merge it.

Reviewer: Savio, Doyensec
Plugin: Apache Solr Fingerprinter
Feedback: The version.txt was missing a few versions, and the script needed a few small improvements, but it worked first try and the overall quality is good.
Drawbacks: None

[tooryx]

Hi @W0ngL1,

This PR is being reviewed internally and should be merged in a few days.

~tooryx

[W0ngL1]

Thank you @tooryx.