finish review commits

google · Nov 22, 2024 · ec69b34 · ec69b34
1 parent 230203d
commit ec69b34
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...java/com/google/tsunami/plugins/detectors/cves/cve202323752/Cve202323752VulnDetector.java b/...java/com/google/tsunami/plugins/detectors/cves/cve202323752/Cve202323752VulnDetector.java
@@ -48,6 +48,7 @@
 import java.io.IOException;
 import java.time.Clock;
 import java.time.Instant;
+import java.util.NoSuchElementException;
 import javax.inject.Inject;
 
 /** A {@link VulnDetector} that detects the CVE-2023-23752 vulnerability. */
@@ -136,7 +137,7 @@ private boolean isServiceVulnerable(NetworkService networkService) {
 
       // Check if body values match our detection rules
       if (!appConfHttpResponse.bodyString().get().contains("password")
-              || !appConfHttpResponse.bodyString().get().contains("user")) {
+          || !appConfHttpResponse.bodyString().get().contains("user")) {
         return false;
       }
 

diff --git a/.../com/google/tsunami/plugins/detectors/cves/cve202323752/Cve202323752VulnDetectorTest.java b/.../com/google/tsunami/plugins/detectors/cves/cve202323752/Cve202323752VulnDetectorTest.java
@@ -130,7 +130,7 @@ public MockResponse dispatch(RecordedRequest request) throws InterruptedExceptio
           if (request.getPath().equals("/api/index.php/v1/config/application?public=true")) {
             return new MockResponse()
                 .addHeader("Content-Type", "application/json; charset=utf-8")
-                .setBody(LeakedDataJsonSample)
+                .setBody(LEAKED_DATA_JSON_SAMPLE)
                 .setResponseCode(HttpStatus.OK.code());
           }
           return new MockResponse().setResponseCode(404);
@@ -167,7 +167,7 @@ public void detect_whenVulnerable_returnsVulnerability() {
                     .setRecommendation("Upgrade Joomla to 4.2.8 and above versions.")
                     .addAdditionalDetails(
                         AdditionalDetail.newBuilder()
-                            .setTextData(TextData.newBuilder().setText(LeakedDataJsonSample))))
+                            .setTextData(TextData.newBuilder().setText(LEAKED_DATA_JSON_SAMPLE))))
             .build();
 
     // Vulnerable to CVE202323752