Fix: Correctly handle dynamic tags without modifiers #3211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tagger analyzer was splitting dynamic tag values into individual characters when no modifiers were specified. This was due to a check for Iterables that returns True for strings and then extends the string into a list.
This PR fixes the issue by:
This change ensures that dynamic tags are correctly handled, even without modifiers, and prevents unexpected splitting behavior. It also improves compatibility with Timesketch by ensuring all tag values are strings, and it addresses a potential TypeError by preventing None values from being added to the tag list.
closes #3206