Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --skip-create-user option to enable non-interactive deployments #3194

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

raihalea
Copy link
Contributor

@raihalea raihalea commented Oct 2, 2024

What existing problem does this PR solve?
This PR solves the issue of the deploy_timesketch.sh script requiring user interaction during deployments. Specifically, the script prompts for user input to confirm whether to create a user or not, which blocks automated deployment processes. This PR addresses this issue by allowing the script to run non-interactively.

What new feature is being introduced with this PR?
This PR introduces a new --skip-create-user option to the deploy_timesketch.sh script. By passing this option, the script will skip the user creation prompt, enabling non-interactive and automated deployments. This provides greater flexibility for both manual and automated environments.

Checks

  • All tests succeed.
  • Unit tests added.
  • e2e tests added.
  • Documentation updated.

Closing issues

closes #3193

Copy link
Collaborator

@jkppr jkppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jkppr jkppr merged commit 18998e1 into google:master Oct 7, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --skip-create-user option to enable non-interactive deployments
2 participants