Sanitise HTML from Unfurl #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
berggren
commented
Oct 25, 2023
berggren
commented
- Small change to the layout of the unfurl graph.
- Sanitise html before render.
jkppr
requested changes
Oct 25, 2023
There was a problem hiding this comment.
The graph controles inside the graph canvas look great, but they impact the space to operate the graph a lot due to the white blocking bar at the top. I would argue we move them out of the canvas to the top right or add a dotted border in the bottom of the toolbar.
jkppr
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.