Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor verbose analyzer output #2885

Merged
merged 9 commits into from
Sep 13, 2023
Merged

refactor verbose analyzer output #2885

merged 9 commits into from
Sep 13, 2023

Conversation

jkppr
Copy link
Collaborator

@jkppr jkppr commented Sep 7, 2023

  • Small refactor for the the AnalyzerOutput object
  • Adding functions for more easy handling especially around adding entries to the meta attributes.
  • Handling most meta entries transparent for the analyzer author.
  • Updating the Domain analyzer to also make use of the verbose analyzer output!

@jkppr
* refactor analyzer output for easier handling
6290ad9 
* update the domain analyzer to use the verbose output
@jkppr jkppr requested a review from berggren September 7, 2023 15:41
@jkppr jkppr self-assigned this Sep 7, 2023
@jkppr jkppr changed the title small verbose analyzer output refactor refactor verbose analyzer output Sep 8, 2023
berggren
berggren requested changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but add args to docstrings

timesketch/lib/analyzers/interface.py Show resolved Hide resolved
@jkppr jkppr requested a review from berggren September 12, 2023 08:51
berggren
berggren approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@berggren berggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkppr jkppr merged commit 09e21a2 into google:master Sep 13, 2023
@jkppr jkppr deleted the refactor_analyzer_output branch September 13, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berggren berggren berggren approved these changes

Assignees

@jkppr jkppr

Labels
Analyzers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkppr @berggren