Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer Result sync review and rework #2799

Closed
jkppr opened this issue Jun 20, 2023 · 1 comment
Closed

Analyzer Result sync review and rework #2799

jkppr opened this issue Jun 20, 2023 · 1 comment
Assignees

Comments

@jkppr
Copy link
Collaborator

jkppr commented Jun 20, 2023

This issue is meant to list all the problems that have been noticed with the analyzer result sync within the last weeks and track the process to fix those.

  1. Review the handling of the active analyzer states between the AnalyzerList.vue and AnalyzerResults.vue component.
  • With PR Loading indicator active analyzers #2749 we introduce handling of activeAnalyzerTImelines in the store. This is used to sync the "execute analyzers" buttons with the state of the analyzer.
  • Review the Result components on the left panel and the analyzer list if the usage of the store can be used to replace the EventBus events that are currently used to reliably get a sync between active analyzers for all components.
  1. Issue Finished analyzer does not update analyzer results UI #2742 - even when the loading indicator on the Analyzer Results stops and disappears, it continues on the timeline level until the page is reloaded.

  2. When the loading indicator disappears / is done for Analyzer Results it does not add the results to the list below automatically but needs to reload the page to see the results. This should be pushed automatically when the analyzer run finished.

  • The following GIF shows the problem with 2 & 3:
    TS_debug_gif
  1. Related to UI: Display an active analysis counter #2675 second part: We have an indicator on the general Analyzer Results level that shows how many analyzers are in the queue at the moment. We have an indicator on the timeline level that shows that a timeline is still being analyzed. But we miss this on the Analyzer level itself. I'm not sure if this might be too many circles but I would like to give it a try. Use-case is: An analyst can see easily which analyzers are still running and which are finished. See screenshot below for what I mean:
    image

  2. It would be great if we could display another icon for analyzers that have already been run for a given timeline instead of the normal play icon. The goal is to add a logic to the AnalyzerList.vue component that checks which analyzer did run on the selected timelines and replace the icon to a "run again" icon and maybe a pop-up asking the user if they really want to run it again. Since we can select multiple timelines and different combinations, it would also work to display the repeat icons as long as one selected timeline is already covered and allow for an "run only on timelines this was not run yet" option to the pop-up.

@jkppr
Copy link
Collaborator Author

jkppr commented Aug 29, 2023

Closed via #2855
Thanks for all the work!

@jkppr jkppr closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants