Loading indicator active analyzers #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkppr
reviewed
Jul 21, 2023
timesketch/frontend-ng/src/components/Analyzer/AnalyzerList.vue
Outdated
Show resolved
Hide resolved
Only showing timelines in the filter that are ready to be processed by analyzers.
jkppr
reviewed
Aug 22, 2023
timesketch/frontend-ng/src/components/LeftPanel/AnalyzerResultTimeline.vue
Show resolved
Hide resolved
…aaq/timesketch into loading-indicator-active-analyzers
* Fixing UI bug with the retry icon being only removed when reloading the page. * Removing ; due to TS style guide.
jkppr
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses all 5 points of #2799
We will keep the activeAnalyses and the finished analyses/analyzerResults in the store. That way we don't need the EventBus anymore.
As soon as there are new activeAnalyses the AnalyzerResults components starts polling the active analyses. If they change, the Analyzer results are loaded from the backend again and stored in the store.
In the AnalyzerList component, a different icon is shown if the analyzer has been run for ALL currently selected timelines.