Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing incorrect cell names in device documentation #264

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

glatosinski
Copy link
Collaborator

Fixes #163

This PR fixes error cell names in device details section of the documentation.

Signed-off-by: Grzegorz Latosinski <[email protected]>
Signed-off-by: Grzegorz Latosinski <[email protected]>
@glatosinski
Copy link
Collaborator Author

After looking at the documentation and the libraries/ directory there are several inconsistencies that I'm not sure how to solve:

  • sky130_fd_pr__cap_min_m4 does not seem to exist in libraries/,
  • sky130_fd_pr__esd_nfet_g5v0d10v5_nvt does not seem to exist,
  • sky130_fd_pr__nfet_extenddrain and sky130_fd_pr__pfet_extenddrain don't exist in libraries/ - those cell names occur for nfet_20v0_zvt, nfet_20v0, nfet_20v0_iso, nfet_20v0_nvt, nfet_g11v0d16v0, pfet_g5v0d16v0 and pfet_20v0

Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I /think/ this LGTM.

However, it does make me wonder what we mean by Cell Name: and Model Name here?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 29, 2020
@diadatp
Copy link
Contributor

diadatp commented Dec 23, 2020

Has the intention behind Cell Name and Model Name been clarified?
Some of the devices have an associated fixed layout in sky130_fd_pr/cells/ while others only have models. Does that have something to do with it?

Some of the other issues:

  • The generic resistors section does not mention a Cell Name but does specify a "type" and "model".
  • The bipolar (PNP) section mentions the same model (sky130_fd_pr__pnp_05v5) twice whereas the only models available are the subcircuits sky130_fd_pr__pnp_05v5_W3p40L3p40 and sky130_fd_pr__pnp_05v5_W0p68L0p68.
  • There is a mismatch between the models mentioned in the docs and those available in sky130_fd_pr. For example in the case of the MIM capacitors, the mentioned models sky130_fd_pr__model__cap_mim and sky130_fd_pr__cap_mim_m4 do not exist. Instead, sky130_fd_pr__model__cap_mim is part of the name of the file (sky130_fd_pr/models/capacitors/sky130_fd_pr__model__cap_mim.model.spice) that imports the required models and as noted previously, sky130_fd_pr__cap_mim_m4 does not occur anywhere. The correct models are the subcircuits sky130_fd_pr__cap_mim_m3_1 and sky130_fd_pr__cap_mim_m3_2. In this case the cell model distinction makes some sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect cell names in device documentation
3 participants