Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Bugfix - sign_cryptography.CryptographySigner - keyfile opened as text (breaks on Python 3) #172

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix - sign_cryptography.CryptographySigner - keyfile opened as text (breaks on Python 3) #172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
816b92c
Merge pull request #1 from google/master
Halastra Nov 28, 2019
50ce722
Bugfix: CryptographySigner.__init__ fix Python 3 compatibility
Halastra Nov 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions adb/sign_cryptography.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ class CryptographySigner(adb_protocol.AuthSigner):
"""AuthSigner using cryptography.io."""

def __init__(self, rsa_key_path):
with open(rsa_key_path + '.pub') as rsa_pub_file:
with open(rsa_key_path + '.pub', 'rb') as rsa_pub_file:
self.public_key = rsa_pub_file.read()

with open(rsa_key_path) as rsa_prv_file:
with open(rsa_key_path, 'rb') as rsa_prv_file:
self.rsa_key = serialization.load_pem_private_key(
rsa_prv_file.read(), None, default_backend())

Expand Down