Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(worker): raise an exception for invalid source #2933

Merged
merged 2 commits into from
Dec 2, 2024
Merged

fix(worker): raise an exception for invalid source #2933

merged 2 commits into from
Dec 2, 2024

Conversation

cuixq
Copy link
Contributor

@cuixq cuixq commented Nov 28, 2024

Follow up on #2928

Instead of logging the error, raise an exception so that caller is able to add record ID to the error.

@cuixq cuixq mentioned this pull request Nov 28, 2024
Merged
@cuixq cuixq marked this pull request as ready for review November 29, 2024 00:16
andrewpollock
andrewpollock approved these changes Dec 1, 2024
View reviewed changes
Copy link
Contributor

@andrewpollock andrewpollock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cuixq cuixq merged commit b23290c into google:master Dec 2, 2024
11 checks passed
@cuixq cuixq deleted the exception branch December 2, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewpollock andrewpollock andrewpollock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuixq @andrewpollock