Feature/add typename method #8437
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the commit message, it’s important to keep it concise but informative. Here’s a recommended format: Suggested Commit Message: typescript Copy code feat: add TypeName() method to generated C++ tables for type identification - Added a `TypeName()` method to generated C++ code to return the fully qualified type name (namespace.type). - Introduced the `MakeFullyQualifiedName` utility function to construct fully qualified type names. - Added a new `--gen-type-names` flag to `flatc` to enable this feature. - Updated `GenTable` method in `idl_gen_cpp.cpp` to generate the `TypeName()` method when the flag is set.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds a new feature to the FlatBuffers compiler (
flatc) to generate aTypeName()method in each C++ table and struct. This method returns the fully qualified type name (including namespace) as a string.Changes Introduced
MakeFullyQualifiedName, to construct fully qualified names using namespaces and type names.GenTablemethod inidl_gen_cpp.cppto include aTypeName()method in generated C++ classes when a custom flag is enabled.--gen-type-names) toflatcto optionally generate theTypeName()method.Motivation
The
TypeName()method allows developers to access the fully qualified name of a table or struct at runtime, similarly to what Protobuf offers withT::descriptor()->full_name().Usage
With the
--gen-type-namesflag, generated C++ code will include aTypeName()method