Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(c++): add support to std::vector<bool, CustomAlloc> for CreateVector #8373

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(c++): add support to std::vector<bool, CustomAlloc> for CreateVector #8373

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d2c5e27
fix(c++): add support to std::vector<bool, CustomAlloc> for CreateVector
sssooonnnggg Aug 14, 2024
575dd2b
Merge branch 'google:master' into master
sssooonnnggg Aug 21, 2024
6d36720
chore: support c++11
sssooonnnggg Aug 21, 2024
55af8fd
Merge branch 'master' into master
dbaileychess Sep 6, 2024
2f3114a
Merge branch 'master' into master
sssooonnnggg Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions include/flatbuffers/flatbuffer_builder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ template<bool Is64Aware = false> class FlatBufferBuilderImpl {
/// buffer as a `vector`.
/// @return Returns a typed `Offset` into the serialized data indicating
/// where the vector is stored.
template<typename T, typename Alloc = std::allocator<T>>
template<typename T, typename Alloc = std::allocator<T>, typename = typename std::enable_if<!std::is_same<T, bool>::value>::type>
Offset<Vector<T>> CreateVector(const std::vector<T, Alloc> &v) {
return CreateVector(data(v), v.size());
}
Expand All @@ -809,7 +809,8 @@ template<bool Is64Aware = false> class FlatBufferBuilderImpl {
// vector<bool> may be implemented using a bit-set, so we can't access it as
// an array. Instead, read elements manually.
// Background: https://isocpp.org/blog/2012/11/on-vectorbool
Offset<Vector<uint8_t>> CreateVector(const std::vector<bool> &v) {
template<typename T, typename Alloc = std::allocator<T>, typename = typename std::enable_if<std::is_same<T, bool>::value>::type>
Offset<Vector<uint8_t>> CreateVector(const std::vector<T, Alloc> &v) {
StartVector<uint8_t>(v.size());
for (auto i = v.size(); i > 0;) {
PushElement(static_cast<uint8_t>(v[--i]));
Expand Down
Loading