Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Add Automatic-Module-Name to Manifest file #8348

Open
Tracked by #67
danepitkin opened this issue Jul 2, 2024 · 0 comments · May be fixed by #8367
Open
Tracked by #67

[Java] Add Automatic-Module-Name to Manifest file #8348

danepitkin opened this issue Jul 2, 2024 · 0 comments · May be fixed by #8367

Comments

@danepitkin
Copy link

Add Automatic-Module-Name of com.google.flatbuffers to the Manifest file. Other google projects such as Guava have done this: https://github.com/google/guava/blob/3618043d084c07895b03bfa47b631b6cd54749a5/guava/pom.xml#L60-L69

This explicitly sets the module name so that if/when JPMS is supported in flatbuffers, it will not be seen as a breaking change for dependent Java projects that are modularized.
This was referenced Jul 2, 2024
Open
Closed
Merged
@danepitkin danepitkin mentioned this issue Jul 11, 2024
Open
3 tasks
laurentgo added a commit to laurentgo/flatbuffers that referenced this issue Jul 30, 2024
@laurentgo
Add Automatic-Module-Name directive
4a3730d 
Add `Automatic-Module-Name` directive with the value
`com.google.flatbuffers` to flatbuffers-java artifact to enable Java
projects leveraging JPMS to safely refer to this artifact.

Fixes google#8348
@laurentgo laurentgo linked a pull request Jul 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@danepitkin