Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Do not publish modules based on filenames #67

Open
2 of 3 tasks
danepitkin opened this issue Jul 11, 2024 · 2 comments
Open
2 of 3 tasks

[Java] Do not publish modules based on filenames #67

danepitkin opened this issue Jul 11, 2024 · 2 comments
Labels
Type: enhancement New feature or request

Comments

@danepitkin
Copy link
Member

danepitkin commented Jul 11, 2024

Describe the bug, including details regarding any error messages, version, and platform.

Arrow Java should not publish modules based on filenames. Flatbuffers/Protobuf can probably be shaded to avoid this. We can potentially remove usage of jsr305 in favor of another library.

[WARNING] * Required filename-based automodules detected: [flatbuffers-java-24.3.25.jar, jsr305-3.0.2.jar, protobuf-java-3.25.1.jar, protobuf-java-util-3.25.1.jar]. Please don't publish this project to a public artifact repository! *

Component(s)

Java

@laurentgo
Copy link
Contributor

laurentgo commented Jul 11, 2024

Shading is not playing nice with JPMS either.

For flatbuffers, there's a request to add an automatic-module name to the library
For protobuf, it seems like it was done long time ago but the manifest doesn't have the actual entry, so I suspect that the jars have been generated with bazel at some points and are now missing those bits since. Issue was fixed as part of protobuf 26.0
As for jsr305, maybe it should be replaced with jspecify

@danepitkin
Copy link
Member Author

Thank you for looking into this! I'll push on the flatbuffers PR to see if we can get it landed since that seems to be the only good solution we have.

@assignUser assignUser transferred this issue from apache/arrow Nov 26, 2024
@assignUser assignUser added the Type: enhancement New feature or request label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants