Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Damper Voltage Fields #1455

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Added Damper Voltage Fields #1455

wants to merge 10 commits into from

Conversation

pranay2811
Copy link
Contributor

No description provided.

@pranay2811
Update telemetry_fields.yaml
bafaf77 
Added:
bypass_air_damper_voltage_command
outside_air_damper_voltage_command
outside_air_damper_voltage_sensor
exhaust_air_damper_voltage_command
exhaust_air_damper_voltage_sensor
return_air_damper_voltage_command
return_air_damper_voltage_sensor
supply_air_damper_voltage_command
supply_air_damper_voltage_sensor
@pranay2811
Update ABSTRACT.yaml
c0ef7ce 
Added 
ODVM: Outside Air Damper Voltage Monitoring
EDVM: Exhaust Air Damper Voltage Monitoring
RDVM: Return Air Damper Voltage Monitoring
SDVM: Supply Air Damper Voltage Monitoring
@pranay2811
Merge branch 'master' into damper-voltage
cd8f06a
@pranay2811
Added BYPDVM
2e54771 
Bypass Damper Voltage Monitoring
@pranay2811
Copy link
Contributor Author

@shambergoldstein Ready for review

@shambergoldstein shambergoldstein dismissed their stale review November 4, 2024 23:09

validation errors, will need to investigate cause before approval

@pranay2811
Copy link
Contributor Author

@shambergoldstein I am seeing these errors. Wondering why does it say that there is no measurement subfield although voltage is present.

ERROR : Field "bypass_air_damper_voltage_command" is not numeric (has no measurement subfield) but specifies a default value range.
ERROR : Field "outside_air_damper_voltage_command" is not numeric (has no measurement subfield) but specifies a default value range.
ERROR : Field "exhaust_air_damper_voltage_command" is not numeric (has no measurement subfield) but specifies a default value range.
ERROR : Field "return_air_damper_voltage_command" is not numeric (has no measurement subfield) but specifies a default value range.
ERROR : Field "supply_air_damper_voltage_command" is not numeric (has no measurement subfield) but specifies a default value range.

@shambergoldstein
Copy link
Collaborator

Seems like potentially a bug, though it is interesting that it is only on the commands. I will take this to the team and see if anyone has any thoughts on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shambergoldstein shambergoldstein shambergoldstein left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pranay2811 @shambergoldstein